David Cumps

Uhm, that's way too much work to achieve what you want.

See sanity-free.org/.../generic_singleton_pattern_in_csharp.html for a simpler solution.

Why not use new() instead?  Is there some reason you had to use reflection?

Change your public class declaration to:

public class Singleton<T> where T :class, new()

then change your _instance instantiation to:

private static readonly T _instance = new T();

Hi David,

what about my solution?

public abstract class Singleton<T> where T : class, new()

{

   protected Singleton() { }

   private static readonly object _sync = new object();

   private static T _instance;

   public static T Instance

   {

       get

       {

           if (_instance == null)

           {

               lock (_sync)

               {

                   if (_instance == null)

                       _instance = new T();

               }

           }

           return _instance;

       }

   }

}

// usage sample:

public class MyClass : Singleton<MyClass>

{

   protected MyClass() {}

   // ...

}

Let me know!

Oups.... pls, remove my previous comment: it's sooooooooo bad!

1) double-check locking is outdated :-)

2) : where new() and protected paremeterless constructor???

Maybe i was drunk!!!

Sorry.

I figured I was missing some basic component of what you were trying to accomplish.   Makes perfect sense now.

Ah - good point. Sorry I missed that.

Pingback from  rascunho  &raquo; Blog Archive   &raquo; links for 2008-07-16