Code Review - Standing on the shoulders of smart people

re: Code Review - Standing on the shoulders of smart people

Jason Kealey — Tue, 20 Mar 2007 12:44:47 GMT

Cenqua is about to release v1.0 of their Crucible code review product. I've tested the product and it is really nice.

http://www.cenqua.com/crucible

re: Code Review - Standing on the shoulders of smart people

Jonathan Cogley — Tue, 20 Mar 2007 00:06:04 GMT

Jeff,

Interesting that you mention CCO since it is that which drives us to critique the code. We usually notice the code because it stands out from the norm (bad naming or unnecessary complexity or a weird pattern). Once this is identified then if it is especially weird, we will 'blame' it to see the commit messages + the evolution of said code, time of the commit :). Then we fix it so that it doesn't stand out from the norm anymore.

Thanks for posting - the team is looking forward to your Code Camp!

re: Code Review - Standing on the shoulders of smart people

Jeff Schoolcraft — Mon, 19 Mar 2007 22:53:35 GMT

Jonathan, I a bit surprised. One of the side effects of pair programming is "Collective Code Ownership". CCO should go a long way towards creating an ego-less environment.

I'm not immune from human emotion, I too have been caught up with a little pride or hubris in particular bits of code, but I'm guessing you're a lot better off through pairing than a formal, after the fact code review of a code cowboy.

re: Code Review - Standing on the shoulders of smart people

Ted_Graham — Mon, 19 Mar 2007 14:17:15 GMT

Developers are often over-confident, which leads to rewriting of code they don't understand under the guise of refactoring. Code review should not be an excuse to change working code, but should be an attempt to improve the code.