[Laws] John Tobler's "Three Strikes" Refactoring Rule

Comments

# Pawel Pabich said on April 13, 2006 09:52 PM:

I would even replace "three times" with "twice". If you repeat your code it means that something is wrong and I'm deadly serious :).

# John Tobler said on April 14, 2006 03:09 PM:

Regarding the first comment, perhaps my restatement (above) clarifies the seriousness of my "Three Strikes" Refactoring Rule!

About the second, Phil Haack indeed sees this problem in a similar way but he refers to it as "the rule of threes," which would put it in with a stew of ambiguity:

http://www.google.com/search?en&q=%22rule+of+threes%22

I also think my "single context" distinction is essential to defining the "Three Strikes" Refactoring Rule correctly.

Thanks for the feedback!

# John Tobler said on April 14, 2006 03:13 PM:

The Phil Haack comment, above, referred to a comment that has subsequently been withdrawn. The URL where Phil references "the rule of threes" is here:

http://haacked.com/archive/2005/09/19/10231.aspx

Note that Phil's statement of the rule is not really equivalent to mine.

# John Tobler said on April 16, 2006 12:45 AM:

Here was the comment that somehow went missing:

Sender: Jon Galloway
Url: http://weblogs.asp.net/jgalloway
re: [Laws] John Tobler's "Three Strikes" Refactoring Rule
I like it. Phil recommended a "third time refactor" guideline before, too:
http://haacked.com/archive/2005/09/19/10231.aspx
-----

Leave a Comment

Title (required) 

Name (required) 

Your URL (optional)

Comments (required) 

Remember Me?