Shiju Varghese's Blog - All Comments

re: Introduction to Test-Driven Development with ASP.NET MVC

Matthew Miller — Fri, 16 Oct 2009 16:03:50 GMT

Whats the point of the Service class? What is it's single responsibility? The first test highlights the issue. You're testing a controller that consumes the service class, yet all your mocks and expectations are set on the repository class.

Indeed your SetUp method actually creates an instance of the service which means that your controller tests will test both the behavior of the service and the controller. Any change to actual behavior in the service class would likely result in broken controller tests.

In looking at the behavior encapsulated by the code I see only a single method that shouldn't be on the repository or controller and that is the validation of the name. Would saving a category to the DB with an empty name ever be a valid condition? If not then the validation of the category should be moved to a place where this logic can be shared.

Because the logic is so simple here, I would simply place the validation logic on the model directly, but for many more advanced scenarios the logic should be encapsulated on a different object. The more advanced scenarios would then drive the creation of a Service object of some sort.

Overall good explanation of TDD, but the service object is simply unnecessary for the example.

Dependency injection (DI) « Make Your Heart "ba-boom ba-boom" (????????????)

Dependency injection (DI) « Make Your Heart "ba-boom ba-boom" (????????????) — Thu, 15 Oct 2009 15:11:19 GMT

Pingback from Dependency injection (DI) « Make Your Heart "ba-boom ba-boom" (????????????)

re: Default option label for DropDownList in ASP.NET MVC Preview 5

r4 firmware — Mon, 12 Oct 2009 07:39:57 GMT

How do you get it so a blank option will show in the list? If I put a string.Empty there it doesn't add the blank option.

re: Default option label for DropDownList in ASP.NET MVC Preview 5

cshellvb — Thu, 08 Oct 2009 19:19:10 GMT

Ok when I first read this I was ready to complain :P

I thought this empty string would break my Binding in the Controller method for int types that are linked to the drop down.

Then I tested it real quick to get the error for complaining....

Dangit - it returns 0, just like I wanted.

Is this just some black magic in the background that is doing a cast from empty.string to 0 in the background ?

re: ASP.NET MVC Grid View using MVCContrib

kmullings — Fri, 02 Oct 2009 14:01:33 GMT

Thanks Shiju! This is a BIG time saver.

How can I use this for an inline "Add" function?

re: ASP.NET MVC Tip: Dependency Injection with StructureMap

nishant — Fri, 25 Sep 2009 12:32:35 GMT

GR8 Man........

re: ASP.NET MVC Grid View using MVCContrib

Suresh — Tue, 22 Sep 2009 06:27:07 GMT

In aspx page mentioned Html.Grid<Category>. What is this <Category> Please tell me.

re: ASP.net MVC Vs ASP.net Web Form

shiju — Sat, 12 Sep 2009 06:01:05 GMT

@Manoj You can possible to use multiple submit buttons. Check this link stackoverflow.com/.../how-do-you-handle-multiple-submit-buttons-in-asp-net-mvc-framework

re: ASP.net MVC Vs ASP.net Web Form

Manoj — Fri, 11 Sep 2009 10:39:37 GMT

I am new to MVC and haven't formed an opinion or take decision on which way is better. With MVC, is it possible to find what caused the Post to occur considering I have multiple submit buttons (each one doing a separate action at the server end) on the form.

re: ASP.net MVC Vs ASP.net Web Form

jason — Wed, 09 Sep 2009 01:35:04 GMT

right