Steve Wellens - All Comments

re: Can the C# ‘var’ Keyword be Misused?

nicstrong — Fri, 20 Nov 2009 19:33:51 GMT

var dataTable = GetXAsDataTable();

1) Method name hints as to type.

2) Is now more discoverable using intellisence.

3) Variable name hints to type even if declaration is not in displayed.

re: Can the C# ‘var’ Keyword be Misused?

Mattias Jakobsson — Fri, 20 Nov 2009 07:17:07 GMT

I agree with "paul.vencill" on this one. As long as you use any tool other then notepad (or similar) then why do you need to know what type you are actually using? Isn't the methods the important thing? Doesn't visual studio help you there?

If you really need to know the datatype, then just name your variables and methods properly and it's all solved.

Another common misunderstanding I see a lot is the one "Mikael Lundin" describes. IPerson person = new SuperHero();. How is that better then var person = new SuperHero();? You still have a dependency on the class SuperHero, thats a fact. So that will gain you exactly zero advantages. You can still use it in any method that takes a IPerson.

I use var everywhere. And it gain me a few advantages, like easier refactoring, while it has no disadvantages.

My answer to the question is: No, var can not be misused. If you need to declare the type to be able to read the code, you are doing something wrong.

var improves readability

Hadi Hariri — Fri, 20 Nov 2009 07:12:22 GMT

  Countless times I’ve heard the argument that you should use the var keyword with caution, that

var improves readability

Hadi Hariri's Blog — Fri, 20 Nov 2009 07:11:48 GMT

var improves readability

re: Can the C# ‘var’ Keyword be Misused?

Mikael Lundin — Fri, 20 Nov 2009 05:02:01 GMT

I use the var keyword to reduce noise from my code, because most often, the variable type could be considered noise.

As said above, using var should not change the readability of the code. The purpose by using a good variable name and the method name must be much clearer.

Sometimes though, you don't want to use var. When you want to make clear that the variable is a base type of an interface.

IPerson person = new SuperHero();

But I love to use it in a foreach where it is just noise to print out the type of the item.

foreach (var person in persons) { .. }

re: Can the C# ‘var’ Keyword be Misused?

SGWellens — Fri, 20 Nov 2009 01:55:46 GMT

>> So you're saying that the use of "var" in the
>> example harms the code clarity more than the poor
>> function and variable names? Sorry, not buying it.

No, I am not saying that.

I'm saying descriptive names improve maintainability.

re: Can the C# ‘var’ Keyword be Misused?

Jared — Fri, 20 Nov 2009 01:34:30 GMT

So you're saying that the use of "var" in the example harms the code clarity more than the poor function and variable names? Sorry, not buying it.

re: Can the C# ‘var’ Keyword be Misused?

Mark Nijhof — Fri, 20 Nov 2009 01:12:40 GMT

I would say make your variable name more descriptive, that is much more valuable. That way everywhere you use the variable you can read what it means. Also the implementation is much less important then its intent.

re: Can the C# ‘var’ Keyword be Misused?

Brad — Fri, 20 Nov 2009 00:49:57 GMT

I agree with your position on var. In fact I posted a blog, like you, about this very topic.

I have some very specific rules about the usage of var.

www.bradcunningham.net/.../random-nerd-debates-episode-2-var.html

re: Can the C# ‘var’ Keyword be Misused?

SGWellens — Fri, 20 Nov 2009 00:05:44 GMT

I'm surprised some would argue that the function name is important...the variable name is important...but the type name, why it doesn't matter at all!

The more information you can convey with the code text, the more maintainable the code will be.

Perhaps some are guilty of using lazy short-cuts and are trying to defend them. Shame on you! :)